Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Include the workers when npm pack #1167

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

dennypradipta
Copy link
Contributor

Monika Pull Request (PR)

What feature/issue does this PR add

This PR includes the lib/workers directory when running npm pack

How did you implement / how did you fix it

Add the lib/workers in the package.json

How to test

npm pack

Screenshot

Screenshot 2023-11-08 at 15 23 37

Running from the installed pack:
Screenshot 2023-11-08 at 15 31 22

Copy link

@budhihyperjump budhihyperjump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gas!

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #1167 (61292c5) into main (3ee0ca3) will not change coverage.
The diff coverage is n/a.

❗ Current head 61292c5 differs from pull request most recent head e1894de. Consider uploading reports for the commit e1894de to get more accurate results

@@           Coverage Diff           @@
##             main    #1167   +/-   ##
=======================================
  Coverage   61.87%   61.87%           
=======================================
  Files         105      105           
  Lines        3129     3129           
  Branches      536      536           
=======================================
  Hits         1936     1936           
  Misses       1015     1015           
  Partials      178      178           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Contributor

@sapiderman sapiderman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gas! (i dont know who that other guy is!)

@dennypradipta dennypradipta merged commit 4381bb0 into hyperjumptech:main Nov 8, 2023
@dennypradipta dennypradipta deleted the issue/1166 branch November 8, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants